Added authorization via LDAP#1329
Closed
svesh wants to merge 1 commit intoabhinavsingh:developfrom
svesh:ldap-auth
Closed
Added authorization via LDAP#1329svesh wants to merge 1 commit intoabhinavsingh:developfrom svesh:ldap-auth
svesh wants to merge 1 commit intoabhinavsingh:developfrom
svesh:ldap-auth
Conversation
Owner
abhinavsingh
left a comment
abhinavsingh
left a comment
There was a problem hiding this comment.
Thank you for the PR. Good to merge once we can remove python-ldap as a mandatory dependency.
| @@ -1,2 +1,3 @@ | |||
| setuptools-scm == 6.3.2 | |||
| twine==3.8.0 | |||
| python-ldap==3.4.3 | |||
Owner
There was a problem hiding this comment.
- We should not add this as a release requirement
- Since
auth_ldapis just an example plugin, it's upto user to install the dependency if they choose to use this plugin - We kind of do similar thing for other plugins where a dependency might be required.
Otherwise, now to install proxy.py, users will also need to install python-ldap even when not using the plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.